-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116633/#review52276
-----------------------------------------------------------


> will push that once this patch is through review

shouldn't it be the other way around? How would anyone be able to compile test 
your review without those files in the oxygen fonts repo?

- Martin Gräßlin


On March 6, 2014, 4:49 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116633/
> -----------------------------------------------------------
> 
> (Updated March 6, 2014, 4:49 p.m.)
> 
> 
> Review request for Plasma and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> -------
> 
> Change default font settings to Oxygen font
> 
> 
> Depend on kde:oxygen-fonts being installed. oxygen-fonts installs a file 
> called OxygenFontConfig.cmake, which is used for checking the dependency is 
> available.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e249554 
>   src/platformtheme/kfontsettingsdata.cpp 62990ce 
> 
> Diff: https://git.reviewboard.kde.org/r/116633/diff/
> 
> 
> Testing
> -------
> 
> Started kate without a kdeglobals file being present, fonts are picked up 
> correctly.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to