----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review53344 -----------------------------------------------------------
shells/newshell/package/contents/ui/mediacenter.qml <https://git.reviewboard.kde.org/r/116554/#comment37531> This function is not needed, however mainwindow still attempts to call it from void MainWindow::playPlaylist(). You might want to remove that as well as the call to playPlaylist itself. addNewInstanceArgsPlaylist() would still be needed. That code basically handles the case when PMC is already open and then you try to run plasma-mediacenter <file> to play a file. - Shantanu Tushar On March 18, 2014, 4:13 p.m., Harshit Agarwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116554/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 4:13 p.m.) > > > Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and > Sujith Haridasan. > > > Repository: plasma-mediacenter > > > Description > ------- > > Referring to Bug #331040 The functionality of the media starting to play on > the press of the "Play All" button has been implemented. > It has been noted and implemented that the media doesn't start over when new > songs/videos are added to an existing playlist. > > > Diffs > ----- > > browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 > shells/newshell/package/contents/ui/mediacenter.qml bac33c2 > > Diff: https://git.reviewboard.kde.org/r/116554/diff/ > > > Testing > ------- > > The testing has been done through various test scenarios. > > > Thanks, > > Harshit Agarwal > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
