> On March 6, 2014, 2:06 a.m., Hrvoje Senjan wrote: > > startkde.cmake, line 76 > > <https://git.reviewboard.kde.org/r/116625/diff/1/?file=252390#file252390line76> > > > > Why not just change the defaults in frameworkintegration instead of > > writing directly into users settings? > > Martin Gräßlin wrote: > I also don't like that this seems to be at least parsed with every > startup. If it needs to go through our startup and cannot be done in > frameworkintegration I think it should be a kconf update script. > > Sebastian Kügler wrote: > You mean the parsing of kdeglobals on startup of apps? > > That would mean frameworkintegration depends on oxygen-font. I'm not sure > that's an acceptable dependency, and I'd like to know for sure that that > approach is acceptable before implementing it. CC:ing Alex Fiestas as the > maintainer of that. > > Alex would you be OK with a runtime dependency on Oxygen font in > frameworkintegration? > >
So we need at least some bits of this, anyway. We can only set the font face and size, but not the hinting method. We'll also need to fiddle with the fontpathes in startkde, that can't be done (sensibly) in frameworksintegration. I've now moved the face and size setting to frameworksintegration and equipped the oxygen-fonts repo with the necessary cmake foo. I'll update this patch for the necessary work shortly. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116625/#review52219 ----------------------------------------------------------- On March 19, 2014, 1:16 a.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116625/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 1:16 a.m.) > > > Review request for Plasma and Àlex Fiestas. > > > Repository: kde-workspace > > > Description > ------- > > Make Oxygen the default font > > This has three portions: the fonts itself, installation of them including > fontconfig bits, and setting font defaults in kdeglobals. > > Oxygen Font 0.4 Imported from oxygen-font repository. > > The startkde portion contains the bits to write out a kdeglobals default > file if it doesn't exist with font settings applied. Usually, with install > prefix set to /usr, the installed oxygen font is found automatically by > fontconfig. If we're installed to a different prefix, we need to point > fontconfig at the font. We do that by linking it from either > XDG_DATA_HOME or ~/.fonts/ and updating fontconfig with it. The latter is > irrelevant for systems that install into /usr. > > > Diffs > ----- > > CMakeLists.txt 0135bb1f7475862451775928adf5dc20167424e0 > fonts/CMakeLists.txt PRE-CREATION > fonts/oxygen/COPYING-GPL+FE.txt PRE-CREATION > fonts/oxygen/GPL.txt PRE-CREATION > fonts/oxygen/Oxygen-Sans-Bold.ttf PRE-CREATION > fonts/oxygen/Oxygen-Sans.ttf PRE-CREATION > fonts/oxygen/OxygenMono-Regular.ttf PRE-CREATION > fonts/oxygen/README PRE-CREATION > startkde.cmake 53d1bc6a2098f634c5f386f95e1a1c504b554303 > > Diff: https://git.reviewboard.kde.org/r/116625/diff/ > > > Testing > ------- > > Logged into session with clean config. Font settings are applied correctly > throughout. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
