----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review54293 -----------------------------------------------------------
If a button doesn't do anything, it should be indicated by disabling it, not just making it a no-op. mediaelements/playlist/Playlist.qml <https://git.reviewboard.kde.org/r/116874/#comment37984> Add { } to the if statement, it makes the code easier to read, and prevents errors when people insert a line without adjusting {} It's also Plasma's recommended coding style. mediaelements/playlist/Playlist.qml <https://git.reviewboard.kde.org/r/116874/#comment37985> indenting is wrong now - Sebastian Kügler On March 27, 2014, 11:22 a.m., R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116874/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 11:22 a.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Bugs: 330990 and Bug > http://bugs.kde.org/show_bug.cgi?id=330990 > http://bugs.kde.org/show_bug.cgi?id=Bug > > > Repository: plasma-mediacenter > > > Description > ------- > > Now the next and previous buttons do not work unless a media is playing. > > > Diffs > ----- > > mediaelements/playlist/Playlist.qml fd83c21 > > Diff: https://git.reviewboard.kde.org/r/116874/diff/ > > > Testing > ------- > > I've done the testing for this patch. > > These are the steps that I followed. > 1. Added a new playlist and added a few songs to the playlist. > 2. Re-opened Plasma Media Center > 3. Clicked the Next and Previous buttons. > 4. Nothing was played. > 5. Selected a song from the list and then tested the next and previous > buttons. > 6. The buttons worked seamlessly. > > > File Attachments > ---------------- > > pulled the latest source and made changes > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/27/7f72b75b-6d72-4a5f-9460-699bb3846624__updated_fix.patch > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
