----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117139/#review54471 -----------------------------------------------------------
You changed automatically translated entries, that's not necessary. You also forgot a bunch of instances, especially all the Comment= entries. browsingbackends/localfiles/localmusic/localmusic.desktop <https://git.reviewboard.kde.org/r/117139/#comment38108> Never edit translated names in .desktop files, they're automatically translated. Only the Name= field is considered, but not for example Name[nl]= Different languages have different capitalization patterns, and the HIG is just the default for English. You don't have to remove it, as it'll be overwritten anyway, just could save a lot of work next time. browsingbackends/localfiles/localpictures/localpictures.desktop <https://git.reviewboard.kde.org/r/117139/#comment38117> missing browsingbackends/localfiles/localvideos/localvideos.desktop <https://git.reviewboard.kde.org/r/117139/#comment38109> Browse Pictures Browse videos Spot the inconsistency? browsingbackends/localfiles/localvideos/localvideos.desktop <https://git.reviewboard.kde.org/r/117139/#comment38116> Needs capitalization browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop <https://git.reviewboard.kde.org/r/117139/#comment38119> Needs capitalization browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop <https://git.reviewboard.kde.org/r/117139/#comment38115> needs capitalization browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop <https://git.reviewboard.kde.org/r/117139/#comment38111> All Videos browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop <https://git.reviewboard.kde.org/r/117139/#comment38114> needs capitalization browsingbackends/onlineservices/youtube/youtubebackend.desktop <https://git.reviewboard.kde.org/r/117139/#comment38113> Videos needs a capital browsingbackends/utility/fullscreen/pmcfullscreen.desktop <https://git.reviewboard.kde.org/r/117139/#comment38112> Needs capitalization as well - Sebastian Kügler On March 28, 2014, 5:12 p.m., Nikolaos Chatzidakis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117139/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 5:12 p.m.) > > > Review request for Plasma and Shantanu Tushar. > > > Repository: plasma-mediacenter > > > Description > ------- > > This patch is created to provide uniform string format to pmc according to > our Visual Design Group's guidelines ( > http://techbase.kde.org/Projects/Usability/HIG/Capitalization ). All menu > strings are converted so words start with capital letter. > > > Diffs > ----- > > > browsingbackends/metadatabackends/metadatamusicbackend/metadatamusicbackend.desktop > 93b7c62 > browsingbackends/localfiles/localvideos/localvideos.desktop 4f22968 > browsingbackends/localfiles/localpictures/localpictures.desktop 4ffe275 > browsingbackends/localfiles/localmusic/localmusic.desktop ab47666 > > browsingbackends/metadatabackends/metadatavideobackend/metadatavideobackend.desktop > 9d04068 > browsingbackends/onlineservices/youtube/youtubebackend.desktop 4b3ba9c > browsingbackends/utility/fullscreen/pmcfullscreen.desktop c992932 > > browsingbackends/metadatabackends/metadatapicturebackend/metadatapicturebackend.desktop > a06a168 > > Diff: https://git.reviewboard.kde.org/r/117139/diff/ > > > Testing > ------- > > > Thanks, > > Nikolaos Chatzidakis > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
