----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117447/#review55272 -----------------------------------------------------------
I like the idea, only two things: * I am not sure about the default, would rather have it empty so everybody that doesn't set it goes in a "misc" section * if this goes in, i would like to see sprinter's querymatch have the same, to avoid "oh crap" moments when porting - Marco Martin On April 9, 2014, 11:18 a.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117447/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 11:18 a.m.) > > > Review request for Plasma and Aleix Pol Gonzalez. > > > Repository: krunner > > > Description > ------- > > > This string based category is useful in categorizing the results. By > default the category defaults to the name of the runner. > > > Diffs > ----- > > src/querymatch.h afec76e > src/querymatch.cpp 83888f7 > > Diff: https://git.reviewboard.kde.org/r/117447/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
