----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117464/#review55428 -----------------------------------------------------------
This review has been submitted with commit 59a6e7b3fd64b7821c064a5528dd91efe1814665 by Martin Gräßlin to branch master. - Commit Hook On April 10, 2014, 6:20 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117464/ > ----------------------------------------------------------- > > (Updated April 10, 2014, 6:20 a.m.) > > > Review request for Plasma, Aleix Pol Gonzalez and Aurélien Gâteau. > > > Repository: plasma-workspace > > > Description > ------- > > [kglobalaccel] Remove notification support > > KGlobalAccel emitted notifications when: > * a shortcut is pressed > * a new shortcut is registered > > Both are configured with no action at all. Thus the notification is not > of much use. Why it shouldn't show a popup had been discussed on kcd [1]. > > This means the notification right now has nothing more than debug > purpose. While this might be a valid usecase it doesn't make much sense > to do this with KNotification - for this see Aaron's mail [2]. Also e.g. > KWin dropped all notifications for debug purposes for the same reason. > > If there is a need for a kind of notification on global shortcut > triggered or a new registered global shortcut this could also be easily > emulated by adding an explicit signal to the DBus interface. > > This removes the KNotificiation dependency. > > [1] http://lists.kde.org/?t=126463249400002&r=1&w=2&n=16 > [2] http://lists.kde.org/?l=kde-core-devel&m=126463340225306&w=2 > > > Diffs > ----- > > kglobalaccel/CMakeLists.txt b77f85edab091fd260fb9bddb1ddb43df445c5fe > kglobalaccel/globalshortcutsregistry.cpp > 41a351b47a66c24f2e25d0d0d1df9c8a9b6616ef > kglobalaccel/kglobalaccel.notifyrc aec41137180c18a89e21a537b9e73da715b5f55d > kglobalaccel/kglobalacceld.h cb058acd0e1d50c47f3cab0cd9e0a061fd0d7a67 > kglobalaccel/kglobalacceld.cpp 86d54695a4b75dc20b46ba4c9ada398d96093a53 > > Diff: https://git.reviewboard.kde.org/r/117464/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
