----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117563/#review55807 -----------------------------------------------------------
Ship it! seems good, not too much sure about method names shell/panelview.cpp <https://git.reviewboard.kde.org/r/117563/#comment38858> i don't like adoptcontainment name that much. since is a reaction to containment change, would be better like containmentChange() (or better ideas for the name if any) - Marco Martin On April 15, 2014, 12:16 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117563/ > ----------------------------------------------------------- > > (Updated April 15, 2014, 12:16 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > At the moment the Panel didn't have any code to react status changes from the > containment (and therefore its applets). > > This patch aims to add this, only problem being that it doesn't work. The > "unhide requested" and "unhiding" messages are being displayed though. > > I've been looking for the code that does the actual display of the > auto-hiding panels and I wasn't able to find it, help is welcome. > > > Diffs > ----- > > shell/panelview.h 056a1e4 > shell/panelview.cpp 53d690a > > Diff: https://git.reviewboard.kde.org/r/117563/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
