> On April 23, 2014, 11:08 p.m., Albert Astals Cid wrote: > > Seems to be an ulra-hack, but if it works, i guess you should commit it if > > it really helps your users to be able to use your product. > > > > Maybe adding a big "TODO" somewhere to recheck if this is needed later on > > or something. > > Shantanu Tushar wrote: > Our current release is 1.2 and 1.3 will be released in June, these two > will need this hack. After that we will move to a Qt5/KF5 port where we will > not need this. > > I was also wondering if instead of actually committing this to the repo, > we just keep this as a patch for distros to apply. Thoughts? > > Bhushan Shah wrote: > > I was also wondering if instead of actually committing this to the > repo, we just keep this as a patch for distros to apply. Thoughts? > > +1, Also if possible some CMake option which enable plasmaadapter, so > that they don't have to patch but just add cmake flag during configure.
I too agree with Shantanu Tushar. - Sujith ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117691/#review56339 ----------------------------------------------------------- On April 22, 2014, 7:53 p.m., Sinny Kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117691/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 7:53 p.m.) > > > Review request for Plasma and Albert Astals Cid. > > > Repository: plasma-mediacenter > > > Description > ------- > > In Kubuntu 14.04 release, we found that Plasma Media Center was unable to > play video/audio files. Reason behind it was PMC was linking with libplasma > and QtMultimediaKit. libplasma links with libgstreamer1.0 while > QtMultimediaKit links with libgstreamer0.10. > > This patch loads libplasma and unloads it after we are done as suggested on > http://lists.kde.org/?l=kde-devel&m=139811564632441&w=2 . > > > Diffs > ----- > > libs/plasmaadapter/plasmaadapter.cpp PRE-CREATION > libs/plasmaadapter/CMakeLists.txt PRE-CREATION > libs/CMakeLists.txt 7e0a9aa > shells/newshell/CMakeLists.txt 9d9ea29 > shells/newshell/mainwindow.h eb2b276 > shells/newshell/mainwindow.cpp 9735a0a > > Diff: https://git.reviewboard.kde.org/r/117691/diff/ > > > Testing > ------- > > Able to play audio/video on Kubuntu 14.04 and Fedora 19. > > > Thanks, > > Sinny Kumari > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
