----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117762/#review56483 -----------------------------------------------------------
CMakeLists.txt <https://git.reviewboard.kde.org/r/117762/#comment39419> What you actually want is to use OPTIONAL_COMPONENTS, I reckon. This can be combined with the previous find_package call. The issue is that you change the FOUND status of XCB as a whole if you search for a COMPONENT that is not found, even if you do it in a separate find_package call. - Alex Merry On April 25, 2014, 8:16 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117762/ > ----------------------------------------------------------- > > (Updated April 25, 2014, 8:16 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > * Only find what is really needed > * XCB-XKB as optional dependency for the keyboard kcm > > > Diffs > ----- > > CMakeLists.txt c548c0e > kcms/CMakeLists.txt 3b21c2f > kcms/input/CMakeLists.txt 1257b80 > kcms/kfontinst/lib/CMakeLists.txt a133956 > > Diff: https://git.reviewboard.kde.org/r/117762/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel