----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117814/#review56817 -----------------------------------------------------------
Wouldn't making the examples work without installation been a better fix? As a sidenote, I wonder why the frameworks group wasn't added to this review, are we missing some bit of config somewhere? I found it thanks to kde-commits. - Kevin Ottens On April 28, 2014, 5:35 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117814/ > ----------------------------------------------------------- > > (Updated April 28, 2014, 5:35 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Make examples optional (default to off) > > > Most users won't want to have tech demos on their real system. > > > Diffs > ----- > > CMakeLists.txt bc5d6d0 > > Diff: https://git.reviewboard.kde.org/r/117814/diff/ > > > Testing > ------- > > Build both variants editing flag with CCMake > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
