> On May 6, 2014, 10:01 p.m., David Faure wrote: > > See my commit b988ccda0f741eb5475210266f887d7fdf6f8115 in kio-extras. > > > > Alexander Richardson wrote: > Okay, I guess this review can be dropped then, right? > > David Faure wrote: > Yes, I think so. Feel free to commit the unit tests though, that's always > good to keep :)
Well, except that concatenation isn't the right way to create URLs, so (QStringLiteral("file://") + QDir::homePath()) should be QUrl::fromLocalFile(QDir::homePath()).toString() - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/#review57458 ----------------------------------------------------------- On May 6, 2014, 12:42 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118017/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 12:42 p.m.) > > > Review request for Plasma and David Faure. > > > Repository: kio-extras > > > Description > ------- > > With QUrl we have to set the scheme manually, seems like KUrl defaulted to > file://. > > Also removed the !isMalformed in the codition, QUrl("~") is malformed, > whereas KUrl("~") was not > > > Diffs > ----- > > kurifilter-plugins/shorturi/kshorturifilter.cpp > 58f3435f7599acf692a082d216a0c58684bcf8b6 > > Diff: https://git.reviewboard.kde.org/r/118017/diff/ > > > Testing > ------- > > Added unit test in KIO, works now > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel