> On May 8, 2014, 11:38 a.m., Burkhard Lück wrote: > > ksmserver/screenlocker/kcm/CMakeLists.txt, line 2 > > <https://git.reviewboard.kde.org/r/118038/diff/2/?file=271973#file271973line2> > > > > You define a TRANSLATION_DOMAIN screenlocker_kcm here, but where is the > > Messages.sh to ectract strings into the catalog screenlocker_kcm?
yep, I will add these things in a second round once the design has settled and I can adjust the code for it. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118038/#review57560 ----------------------------------------------------------- On May 8, 2014, 7:17 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118038/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 7:17 a.m.) > > > Review request for Plasma and Thomas Pfeiffer. > > > Repository: plasma-workspace > > > Description > ------- > > Bring back a KCM for the screen locker > > Note: I will improve the default values to get them sane. That needs > adjustements in the screenlocker source base and I want to get the review of > the UI started earlier. > > > Diffs > ----- > > ksmserver/screenlocker/kcm/screenlocker.desktop PRE-CREATION > ksmserver/screenlocker/kcm/kcm.ui PRE-CREATION > ksmserver/screenlocker/kcm/CMakeLists.txt PRE-CREATION > ksmserver/screenlocker/kcm/kcm.cpp PRE-CREATION > ksmserver/screenlocker/CMakeLists.txt > 3407ea46d5046f2f5b2e7321d714ad1e65ffceea > > Diff: https://git.reviewboard.kde.org/r/118038/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > KCM with values > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/f70f34d6-2c5c-4638-8e43-d9d727fdb7cb__kcm-with-values.png > KCM without values > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/89b1ef8e-803f-42fb-b2cb-52b776246598__kcm-without-values.png > In Systemsettings > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/08/65025e3c-30d1-4d91-8173-314fecb39241__kcm-in-systemsettings.png > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
