> On May 8, 2014, 5:21 p.m., David Edmundson wrote: > > ksmserver/screenlocker/autotests/CMakeLists.txt, line 30 > > <https://git.reviewboard.kde.org/r/117995/diff/1/?file=271561#file271561line30> > > > > does running ctest in the build directory try to run this? We don't > > want that to happen. > > > > Same for pointer grabber.
no, ecm_mark_as_test only marks the binary that it is a test application. But it's not added as a test. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117995/#review57591 ----------------------------------------------------------- On May 5, 2014, 1:32 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117995/ > ----------------------------------------------------------- > > (Updated May 5, 2014, 1:32 p.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: plasma-workspace > > > Description > ------- > > [screenlocker] Add a unit test for KSldApp > > The unit test so far only tests establishGrab. This is a little bit > tricky as we need a different X Client which grabs pointer or keyboard > to make establishGrab fail. For that two small helper applications are > included which do nothing else than connecting to X and the one grabbing > keyboard the other grabbing pointer. > > The applications are started from the test to get the keyboard/pointer > grabbed which results in ::establishGrab to return false. > > What this test is not yet able to test is handling the sleep between two > grab attemps. > > > Diffs > ----- > > ksmserver/screenlocker/autotests/CMakeLists.txt > ff95d9d031cdac32085e358e30b95a9e9a6fb7dc > ksmserver/screenlocker/autotests/keyboardgrabber.cpp PRE-CREATION > ksmserver/screenlocker/autotests/ksldtest.cpp PRE-CREATION > ksmserver/screenlocker/autotests/pointergrabber.cpp PRE-CREATION > ksmserver/screenlocker/ksldapp.h 958b55c1ff83e21d57e3c1dfb812016f325046be > > Diff: https://git.reviewboard.kde.org/r/117995/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel