----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/ -----------------------------------------------------------
(Updated May 23, 2014, 2:05 p.m.) Review request for Plasma and Kai Uwe Broulik. Changes ------- Addressed comments. Thanks guys! There are also a few reference error fixes in CompactRepresentation and batterymonitor in there now. Repository: plasma-workspace Description ------- Clean up Battery Monitor This patch simplifies the battery's ui, and brings spacing in line with Plasma 5 standards. In detail: - removing the selection item on batteries: it's already visible by the text shown that the battery is selected. It also doesn't need the selection semantics across the ui, because -- for what? - remove separator lines, in Plasma 5, we use spacing for this case - align extra battery info to the slider, improves logical grouping - Improve HighDPI by removing hard-coded layout hints, use units.gridUnit throughout - Fix batteryitem's status: it would show the wrong icon and time label, because AC Adapter can be empty. Checking charging is semantically correct here, since it uses the charge state, not the adapter state. - remove a bunch of SVGs that were used internally to get margins -- use gridUnit for layout internal margins instead - fix slider's right alignment, this would jump based on the percentage label's width, which varies per item. We know the rough length of the percentage label from the context, and can align the labels to that. Code is also in kde-workspace[sebas/batterycleanup]. Diffs (updated) ----- applets/batterymonitor/contents/ui/BatteryItem.qml 431aa9a applets/batterymonitor/contents/ui/BrightnessItem.qml a91ccde applets/batterymonitor/contents/ui/CompactRepresentation.qml 8d7b26e applets/batterymonitor/contents/ui/PopupDialog.qml 0444199 applets/batterymonitor/contents/ui/PowerManagementItem.qml 530fce3 applets/batterymonitor/contents/ui/batterymonitor.qml 7536f95 Diff: https://git.reviewboard.kde.org/r/118272/diff/ Testing ------- Tested with plasmoidviewer and in the shell, plugging ac in and out, tried different combinations of values. File Attachments ---------------- before (collapsed) https://git.reviewboard.kde.org/media/uploaded/files/2014/05/22/abc1d750-6eb7-4728-a5f2-e9f8566b5b44__battery-before-collapsed.png before (expanded) https://git.reviewboard.kde.org/media/uploaded/files/2014/05/22/2a0b9ad3-03e8-4f07-a158-ceb0d3d0e23c__battery-before-expanded.png after (collapsed) https://git.reviewboard.kde.org/media/uploaded/files/2014/05/22/4439093c-345c-44af-afa1-a05cb0973990__battery-after-collapsed.png after (expanded) https://git.reviewboard.kde.org/media/uploaded/files/2014/05/22/b18cf61f-0ff1-4e91-93c2-ebd6b1dab38d__battery-after-expanded.png Thanks, Sebastian Kügler
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel