----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118254/ -----------------------------------------------------------
(Updated May 27, 2014, 11:27 a.m.) Status ------ This change has been discarded. Review request for Plasma. Repository: plasma-framework Description ------- hello, This patch adds a new interceptor for our shell packages. Right now we cannot load an svg if the image is inside the /contents/images of the shell package. So this patch solves that issue. Diffs ----- src/plasma/private/packages.cpp fa0fc6a src/plasmaquick/CMakeLists.txt cc5554a src/plasmaquick/shellurlinterceptor.h PRE-CREATION src/plasmaquick/shellurlinterceptor.cpp PRE-CREATION src/plasmaquick/view.cpp 5aa1102 Diff: https://git.reviewboard.kde.org/r/118254/diff/ Testing ------- *Testing* org.kde.desktop shell package works without any issue. *Issues* The interceptor doesn't return a scheme for the svg component. PlasmaCore.SvgItem { svg: PlasmaCore.Svg { imagePath: "shellpackage:/images/bar.svgz" } } On the above code, the "path.scheme()" from the interceptor never returns "shellpackage", so it is completely ignored. But the following one it works Image { source: "shellpackage:/images/foo.png" } Thanks, Antonis Tsiapaliokas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel