> On May 27, 2014, 10:36 p.m., Kai Uwe Broulik wrote: > > src/plasmaquick/dialog.cpp, line 800 > > <https://git.reviewboard.kde.org/r/118361/diff/1/?file=275561#file275561line800> > > > > Isn't comparison more efficient using QLatin1String?
Last time I've heard it's not anymore in Qt5 thanks to QStringLiteral...is it still? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118361/#review58609 ----------------------------------------------------------- On May 27, 2014, 9:13 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118361/ > ----------------------------------------------------------- > > (Updated May 27, 2014, 9:13 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > When plasmoid in a popup is opening a QMenu, the popup itself hides because > it looses focus. This patch fixes it. > > > Diffs > ----- > > src/plasmaquick/dialog.cpp d8e263c > > Diff: https://git.reviewboard.kde.org/r/118361/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
