----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118373/#review58643 -----------------------------------------------------------
Ship it! Yes, it doesn't make much sense to delete it only in case of error. - Aleix Pol Gonzalez On May 28, 2014, 10:33 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118373/ > ----------------------------------------------------------- > > (Updated May 28, 2014, 10:33 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > Do not delete passed objects to createObjectFromComponent > > Without this patch we can get a crash if createObjectFromComponent is > called with the same component twice. > > > Diffs > ----- > > src/kdeclarative/qmlobject.cpp 7e2a3b8 > > Diff: https://git.reviewboard.kde.org/r/118373/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
