> On May 30, 2014, 3:15 p.m., David Edmundson wrote: > > klipper/urlgrabber.cpp, line 147 > > <https://git.reviewboard.kde.org/r/118423/diff/1/?file=276477#file276477line147> > > > > this comment doesn't seem true, we explicitly check if the mimetype is > > html
I read this comment different: if clipboard contents starts with http, enforce the mimetype to be html, because that's what's being done in the if - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/#review58802 ----------------------------------------------------------- On May 30, 2014, 3:02 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118423/ > ----------------------------------------------------------- > > (Updated May 30, 2014, 3:02 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > [klipper] Port KMimeType to QMimeType > > > Diffs > ----- > > klipper/urlgrabber.cpp 4eccb7065ae2932cc548c902ab3a8c50e4972444 > > Diff: https://git.reviewboard.kde.org/r/118423/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel