----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118813/#review60399 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On June 18, 2014, 12:19 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118813/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 12:19 p.m.) > > > Review request for Plasma. > > > Bugs: 336272 > http://bugs.kde.org/show_bug.cgi?id=336272 > > > Repository: plasma-framework > > > Description > ------- > > [declarativeimports/core] Do not crash if FadingMaterialShader failed to > complie > > Without GLSL our shader doesn't compile and Qt aborts when accessing the > uniforms. We don't want that, abort is never nice. > > BUG: 336272 > > > Diffs > ----- > > src/declarativeimports/core/fadingnode.cpp > 0c41ec1f4cc2fe78af59dfb1c705bbc65697380b > > Diff: https://git.reviewboard.kde.org/r/118813/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
