----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118665/#review60510 -----------------------------------------------------------
Ship it! Ship It! - David Edmundson On June 13, 2014, 8:40 a.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118665/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 8:40 a.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: oxygen > > > Description > ------- > > Valgrind pointed out ~ShadowHelper uses _helper, but at the time > ~ShadowHelper is called, _helper has already been deleted. Deleting > ShadowHelper manually works around this problem. I also have an alternative > patch which turns _helper into a QSharedPointer, which I can submit instead, > but the changes are much more invasive. > > > Diffs > ----- > > kstyle/oxygenstyle.cpp 972e4c8 > > Diff: https://git.reviewboard.kde.org/r/118665/diff/ > > > Testing > ------- > > Running "valgrind kcmshell5 desktop" does not print any error about invalid > reads in ~ShadowHelper anymore. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
