-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118869/
-----------------------------------------------------------

(Updated June 23, 2014, 11:03 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Aaron J. Seigo.


Bugs: 336551
    http://bugs.kde.org/show_bug.cgi?id=336551


Repository: kdelibs


Description
-------

As described in bug 336551, plasma data engines use QTime to find out about 
elapsed time. The problem is that QTime handles time zones, and therefore reads 
/etc/localtime on each call.

Instead, it should use QElapsedTimer. This fixes both the performance issue, as 
well as the FIXME from the comment about not handled 24-h wraps and timezone 
changes.

There are probably more places where this can be changed.


Diffs
-----

  plasma/datacontainer.cpp d19b1a5 
  plasma/dataengine.cpp 9612574 
  plasma/private/datacontainer_p.h a3e1f00 
  plasma/private/dataengine_p.h 74a61e2 

Diff: https://git.reviewboard.kde.org/r/118869/diff/


Testing
-------


Thanks,

Christoph Feck

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to