> On June 23, 2014, 3:10 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 28 > > <https://git.reviewboard.kde.org/r/118900/diff/1/?file=284116#file284116line28> > > > > If you want these to be optional, you can pass them in > > OPTIONAL_COMPONENTS, from the top find_package.
It looks like the REQUIRED statement takes precedence over any subsequent OPTIONAL_COMPONENTS; it's still treated as required. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118900/#review60808 ----------------------------------------------------------- On June 23, 2014, 3:07 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118900/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 3:07 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > KF5WebKit is only used if drkonqi is built with (optional) KF5XmlRpcClient. > Qt5Concurrent is only required for tests. > > > Diffs > ----- > > CMakeLists.txt 4bfa2e93abfc6f8087693c363e5982fa862cf0fa > drkonqi/CMakeLists.txt 8224900e633c18f57ac3fbc7e5a77a8f5a34edb0 > > Diff: https://git.reviewboard.kde.org/r/118900/diff/ > > > Testing > ------- > > Inspected source, builds, tests pass. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
