----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118896/#review60987 -----------------------------------------------------------
This review has been submitted with commit 09dd2a2a20b7fcd5382e8b139e1843da4437cba9 by David Faure to branch master. - Commit Hook On June 25, 2014, 10:51 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118896/ > ----------------------------------------------------------- > > (Updated June 25, 2014, 10:51 p.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Repository: kdelibs > > > Description > ------- > > Fix 2 data races in runnercontext, mention another one. > > Found by helgrinding krunner. Turns out helgrind lacks support for > QReadWriteLock, but reading the code still made me found these. > > > Diffs > ----- > > plasma/private/runnerjobs.cpp 6a8a7710f95adba38cc56c2d59393bfa3b123185 > plasma/runnercontext.cpp abd6a4bc7fca2a0d05f27c6601b658ff552307b3 > > Diff: https://git.reviewboard.kde.org/r/118896/diff/ > > > Testing > ------- > > Typing various things into krunner. > > The main crash is still there though: baloo or xapian isn't reentrant; but > that's separate. > > > Thanks, > > David Faure > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
