> On Lug. 20, 2014, 4:11 p.m., David Edmundson wrote:
> > lookandfeel/contents/components/LogoutOptions.qml, line 64
> > <https://git.reviewboard.kde.org/r/119379/diff/1/?file=291353#file291353line64>
> >
> >     I think this may need to be i18ncd; unless someone is setting the 
> > catalog on the c++ side. 
> >     Current code has a mix, so Im not sure.
> 
> Frederik Gladhorn wrote:
>     That was actually the main reason for the review request - I dunno how 
> the catalog stuff works these days. It would be great if someone could shed 
> some light on this :)

not sure if who loads the lockscreen qml sets a default domain. If not, it 
needs a domain set explicitly (like the same as the package name may work)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119379/#review62741
-----------------------------------------------------------


On Lug. 20, 2014, 4:05 p.m., Frederik Gladhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119379/
> -----------------------------------------------------------
> 
> (Updated Lug. 20, 2014, 4:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Make lockscreen buttons say something and let shutdown/lock/reboot buttons 
> get focus.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/components/LogoutOptions.qml d3ccea0 
>   lookandfeel/contents/components/UserDelegate.qml 2221368 
> 
> Diff: https://git.reviewboard.kde.org/r/119379/diff/
> 
> 
> Testing
> -------
> 
> Tested with Orca.
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to