----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119384/#review62773 -----------------------------------------------------------
Ship it! You should also center it horizontally activeshellpackage/package/contents/explorer/AppletDelegate.qml <https://git.reviewboard.kde.org/r/119384/#comment43520> I'm not sure it it should add it immediately or add it to a list and then mass-add on ok pressed, let's try to see what happens with immediate add+close of the window activeshellpackage/package/contents/views/Desktop.qml <https://git.reviewboard.kde.org/r/119384/#comment43517> in this case we want focus and to close it when the focus gets lost (clicked outside) activeshellpackage/package/contents/views/Desktop.qml <https://git.reviewboard.kde.org/r/119384/#comment43518> don't hardcode, use a good margin based on units.gridUnit (that makes it remain a couple of centimeters at left, right and top) - Marco Martin On Lug. 21, 2014, 11:48 a.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119384/ > ----------------------------------------------------------- > > (Updated Lug. 21, 2014, 11:48 a.m.) > > > Review request for Plasma and Marco Martin. > > > Repository: plasma-mobile > > > Description > ------- > > This patch make the widget explorer more friendly on touch devices. > > > Diffs > ----- > > activeshellpackage/package/contents/explorer/AppletDelegate.qml 35c62fc > activeshellpackage/package/contents/explorer/Tooltip.qml 0eafa19 > activeshellpackage/package/contents/explorer/WidgetExplorer.qml 9ad9b88 > activeshellpackage/package/contents/views/Desktop.qml 6582fd7 > > Diff: https://git.reviewboard.kde.org/r/119384/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > widget exploer > > https://git.reviewboard.kde.org/media/uploaded/files/2014/07/21/522038d2-b4da-4c34-9d9c-11aa5666fe8d__widgetexplorer.png > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
