----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119406/#review62911 -----------------------------------------------------------
Two issues: - Existing Dialog instances don't get the corner mask applied correctly when switching from transparent to opague: ![Shot](http://wstaw.org/m/2014/07/23/cornermask.png) - Compiler warning: framesvgitem.cpp:119:10: warning: unused parameter ‘composeOverBorder’ [-Wunused-parameter] void updateTexture(const QSize &size, const QString &elementId, bool composeOverBorder) - Eike Hein On July 22, 2014, 2:24 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119406/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 2:24 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Always take the painter based path for composeOverBorder > > We previously only supported compose-over-border when the centre was not > set to tile. > > A recent change to the breeze theme put everything into tiling, even if > some things used compose-over-border, which broke opaque widgets. > > Given that creating an opacityMask loads most of the image anyway, we > can make use of the FrameSVG painter path and avoid any additional code > complexity here. > > > Diffs > ----- > > src/declarativeimports/core/framesvgitem.cpp a5fe315 > > Diff: https://git.reviewboard.kde.org/r/119406/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel