----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119430/#review62988 -----------------------------------------------------------
Ship it! Good catch, patch seems sane. Thanks for fixing this issue! - Sebastian Kügler On July 23, 2014, 4:54 p.m., Anton Kreuzkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119430/ > ----------------------------------------------------------- > > (Updated July 23, 2014, 4:54 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Repository: plasma-workspace > > > Description > ------- > > The systemtray plugin for dbus-activated plasmoids removed the > plasmoid as soon as a service vanished, that matched the pattern. > This behavior broke as soon as there're multiple matchin services, > e.g. the mediacontroller plasmoid when multiple mpris2-mediaplayers > are started. As soon as you quit one application, the plasmoid would > get removed. > > With this patch the plasmoid only gets removed after the last service > quit. > > > Diffs > ----- > > applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.h > e77bae1f58377068be7c306d56073b626240abcd > applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp > 992c7f3226cc0f71c085e9148179b2e44dcd2e4f > > Diff: https://git.reviewboard.kde.org/r/119430/diff/ > > > Testing > ------- > > Only tested with mediacontroller plasmoid. Works there. > > > Thanks, > > Anton Kreuzkamp > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel