> On July 24, 2014, 10:55 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 45 > > <https://git.reviewboard.kde.org/r/119425/diff/2/?file=292260#file292260line45> > > > > Having spoken to you offline this does make sense, but it needs > > documentation as to why it's doing this.
uhm, why a filter on palette change? this would work for themes that use system colors but not the other ones. theme::themechanged should cover both cases (and if it doesn't, it should) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119425/#review63049 ----------------------------------------------------------- On July 24, 2014, 12:44 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119425/ > ----------------------------------------------------------- > > (Updated July 24, 2014, 12:44 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Create a cache that has pointers to all the textures that we've generated, so > in case we have one already created, we can re-use it. > > > Diffs > ----- > > src/declarativeimports/core/framesvgitem.cpp 323b06b > src/declarativeimports/core/iconitem.cpp 38012cc > src/declarativeimports/core/svgitem.cpp eccff55 > src/declarativeimports/core/svgtexturenode.h 21b9b2f > > Diff: https://git.reviewboard.kde.org/r/119425/diff/ > > > Testing > ------- > > see the qDebug (to be removed before commit). > > plasmashell 2> out > $ grep s_cache out | grep ": miss" | wc -l > 342 > $ grep s_cache out | grep ": hit" | wc -l > 126 > > So still having 3 times more hits than miss, so there's big room for > improvement. Good news is that with this, we get a ~25% of memory and > bandwidth save, in a per-item basis. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel