> On July 25, 2014, 10:44 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 76 > > <https://git.reviewboard.kde.org/r/119455/diff/4/?file=292603#file292603line76> > > > > This causes a behavioural change: > > > > look at line 102 of the old Button.qml > > the minimumWidth was the size of the full text + margins.
right, so let's use just implicitWidth.. last version seems to produce same results for sizing - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63127 ----------------------------------------------------------- On July 25, 2014, 10:55 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119455/ > ----------------------------------------------------------- > > (Updated July 25, 2014, 10:55 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > this makes Button inherit from the QtControl and annd an accompaining > plasma-looking theme > > now, the ugly part of the patch: > iconSource is an url, so it screws up passing freedesktop compatible names > (it expects names of pngs local to the qml file directory, testimony of the > main platform target for controls actually being android/ios). one solution > may be overriding iconSource as a normal string, but i would like the theme > working also on a plain Button, so it extract only the filename from the url. > > > Diffs > ----- > > examples/applets/widgetgallery/contents/ui/Buttons.qml 9134df9 > src/declarativeimports/core/iconitem.cpp 38012cc > src/declarativeimports/plasmacomponents/qml/Button.qml 262e20f > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119455/diff/ > > > Testing > ------- > > in both a normal plasma session or the widget gallery buttons work fine, > painting is 100% identical > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
