> On July 28, 2014, 6:54 p.m., David Edmundson wrote:
> > src/declarativeimports/plasmacomponents/qml/TextField.qml, line 366
> > <https://git.reviewboard.kde.org/r/119523/diff/1/?file=293985#file293985line366>
> >
> > This is going to overlap with the text I think.
> > It might be worth trying to upstream the concept of a clear button
> > rather than working round it here. It'll be less work in the long term.
> >
> > I filed a bug report on this once, they're ok with the concept but want
> > to make it so you can add any random button on the left/right, not just
> > clear.
yes, it does overlap, i don't have much ways to avoid it.
maybe worth it upstreaming yeah, I guess they would like something
TextField {
property Item ActionButton
}
and actionButton would be a whatever item that gets anchored on the right area,
or would that be restricted to a button? (so just being able to set text,
tooltip and a signal handler?)
On July 28, 2014, 6:54 p.m., Marco Martin wrote:
> > Which methods do we need the inner control for? I saw positionAtPos and
> > positionToRectangle, any others?
those two and passwordCharacter
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119523/#review63363
-----------------------------------------------------------
On July 28, 2014, 6:10 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119523/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 6:10 p.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> this ports TextField to Qt Controls.
>
> Not sure if is really meargeable tough, because the old one used to export
> several properties and functions more, but they are not possible anymore,
> because in order for them to work is needed the access to the internal
> TextInput, and we don't have that, so some api should have to be dropped,
> breaking the compatibility promise.
> (another option would be to still use an own implementation, but use a
> compatible style anyways)
>
>
> Diffs
> -----
>
> src/declarativeimports/plasmacomponents/qml/TextField.qml 5bc6b58
> src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml
> PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/119523/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
