> On Aug. 4, 2014, 2:37 p.m., Vishesh Handa wrote: > > It would be nice if you could upload a screenshot. > > Marco Martin wrote: > done. and yep, i know it looks completely screwed at the moment :) (not > exactly sure why the button is so much off center vertically) > it all needs way more work, tough I mostly wanted to know if you tought > was on the right track before putting further work in it > > Vishesh Handa wrote: > To be honest - No. I'm not too fond of the current approach, but I do not > know a better way of doing it. > > Stuff I don't like - > * This whole KCM nonsense where every runner installs their own KCM for > configuring it. > * The whole tab widget thing. We don't have a case where multiple runners > provide the same category, so you're not going to need such an approach. > Though considering that this could hypothetically happen, I can see why this > approach was used. > > As I said, I'm not too fond of it, but I'm not going to stop this from > going in.
not that fan as well, but i think it can be made not too much invasive, combining minimizing regressions with keeping the new category based way - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119602/#review63780 ----------------------------------------------------------- On Aug. 4, 2014, 5:02 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119602/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2014, 5:02 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > unlike the previous one, this still uses category based config. > tough, if in a category there are runners with a config dialog, enable a > config button in the item. > If there would be more runners with config in one category, it would put all > the config dialogs in a tabbar. > The code for showing the config dialog comes from KPluginLoader > > > Diffs > ----- > > kcms/runners/kcm.h 0458430 > kcms/runners/kcm.cpp 0de07fb > > Diff: https://git.reviewboard.kde.org/r/119602/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > krunner.png > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/04/447dbfb8-e813-4cb9-aabb-a2b9f8d324a0__krunner.png > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
