----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119669/#review64233 -----------------------------------------------------------
Ship it! Once issue is fix, good to go! startkde/kstartupconfig/kdostartupconfig.cpp <https://git.reviewboard.kde.org/r/119669/#comment44890> Add const if string is not modified down the line. - Àlex Fiestas On ago. 8, 2014, 4:09 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119669/ > ----------------------------------------------------------- > > (Updated ago. 8, 2014, 4:09 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Fix broken creation of kstartupconfigfiles > > kstartupconfigfiles contains a list of files to compare mtimes on to see > if we need to rebuild kstartupconfig. This wasn't being created > correctly so we failed to rebuild if any configs updated. > > This was broken in Qt5 porting: > - const QStringList dirs = > KGlobal::dirs()->kfsstnd_prefixes().split( KPATH_SEPARATOR, > QString::SkipEmptyParts); > + const QStringList dirs = > QStandardPaths::standardLocations(QStandardPaths::GenericDataLocation); > > > Diffs > ----- > > startkde/kstartupconfig/kdostartupconfig.cpp af6062c > > Diff: https://git.reviewboard.kde.org/r/119669/diff/ > > > Testing > ------- > > Checked output of kstartupconfigfiles was sane. > Updated ksplashrc, ran kstartupconfig5 (NOT kdostartupconfig5) checked > kstartupconfig was regenerated. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
