> On Aug. 27, 2014, 9:58 a.m., David Edmundson wrote: > > shell/main.cpp, line 43 > > <https://git.reviewboard.kde.org/r/119943/diff/3/?file=307797#file307797line43> > > > > this is already shipped? > > your diffs are a bit messed up.
eww, yeah, doing diff from the wrong checkout > On Aug. 27, 2014, 9:58 a.m., David Edmundson wrote: > > plasma-windowed/main.cpp, line 69 > > <https://git.reviewboard.kde.org/r/119943/diff/3/?file=307784#file307784line69> > > > > this will include the applet name again, is that intentional? args should be only the parameters from the second onwards? > On Aug. 27, 2014, 9:58 a.m., David Edmundson wrote: > > plasma-windowed/plasmawindowedview.cpp, line 131 > > <https://git.reviewboard.kde.org/r/119943/diff/3/?file=307792#file307792line131> > > > > on every mouseMove? not mouse move, just window move, so dragging from the titlebar and similar (maybe still a bit too much, but writing on config without syncing should be fast i think?) > On Aug. 27, 2014, 9:58 a.m., David Edmundson wrote: > > plasma-windowed/plasmawindowedview.cpp, line 134 > > <https://git.reviewboard.kde.org/r/119943/diff/3/?file=307792#file307792line134> > > > > what's this for? if the window is closed, both the window and the applet get deleted, they are considered closed (since the same process can open more than one window/applet) it does delete and not destroy to preserve the config - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119943/#review65346 ----------------------------------------------------------- On Aug. 27, 2014, 9:32 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119943/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2014, 9:32 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > this is a rewrite of the plasma windowed shell and the associated runner, in > order to have plasmoids as mini applications. > > > Diffs > ----- > > runners/windowedwidgets/CMakeLists.txt ca31b29 > runners/windowedwidgets/windowedwidgetsrunner.h 13e9f43 > runners/windowedwidgets/windowedwidgetsrunner.cpp 4773bcd > shell/main.cpp 0d53bf5 > CMakeLists.txt 6642d78 > plasma-windowed/CMakeLists.txt PRE-CREATION > plasma-windowed/main.cpp PRE-CREATION > plasma-windowed/plasma-windowed.desktop PRE-CREATION > plasma-windowed/plasmaquick/configview.h PRE-CREATION > plasma-windowed/plasmaquick/shellpluginloader.h PRE-CREATION > plasma-windowed/plasmaquick/view.h PRE-CREATION > plasma-windowed/plasmawindowedcorona.h PRE-CREATION > plasma-windowed/plasmawindowedcorona.cpp PRE-CREATION > plasma-windowed/plasmawindowedview.h PRE-CREATION > plasma-windowed/plasmawindowedview.cpp PRE-CREATION > runners/CMakeLists.txt fe4e322 > > Diff: https://git.reviewboard.kde.org/r/119943/diff/ > > > Testing > ------- > > they correctly save and restore settings, it supports one plasmoid per type, > window geometries are been saved and restored as well. > still missing a first default size of the window coming from hints, but that > will a bit more complicated (if possible at all) > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel