> On Aug. 28, 2014, 1:46 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml, line 35 > > <https://git.reviewboard.kde.org/r/119974/diff/1/?file=307982#file307982line35> > > > > in the last review we explicilty set panel to Item {} > > > > if it's needed there, it's needed here.
no, that was background, that slider doesn't have it. panel is the internal piece that actually loads the other components, so shouldn't be reimplemented usually > On Aug. 28, 2014, 1:46 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml, line 40 > > <https://git.reviewboard.kde.org/r/119974/diff/1/?file=307982#file307982line40> > > > > Have you tried in vertical mode. > > We don't seem to handling orientation anywhere? > > > > (maybe it's done for us, I haven't looked) yes, vertical works it's done internally just brutally rotating the whole thing > On Aug. 28, 2014, 1:46 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml, line 71 > > <https://git.reviewboard.kde.org/r/119974/diff/1/?file=307982#file307982line71> > > > > where is styleData defined? > > Seems we're accidentally relying on private API. it's internal but it's documented, so should be guaranteed to stay. http://qt-project.org/doc/qt-5/qml-qtquick-controls-styles-sliderstyle.html#groove-prop it's the only way to have the colored part properly sized > On Aug. 28, 2014, 1:46 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml, line 86 > > <https://git.reviewboard.kde.org/r/119974/diff/1/?file=307982#file307982line86> > > > > Won't this position them outside the repeater? i think so, but seems the wanted way since they gets correctly positioned. it's just an 1:1 copy of the one in the Base style, just with the proper colors - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119974/#review65431 ----------------------------------------------------------- On Aug. 28, 2014, 12:30 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119974/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2014, 12:30 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > this ports slider to qtcontrols and adds a style as well. > unfortunately the inverted property is not accessible anymore so becomes > deprecated and noop > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/Slider.qml c532590 > src/declarativeimports/plasmacomponents/qml/styles/SliderStyle.qml > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119974/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
