----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119989/ -----------------------------------------------------------
(Updated Aug. 29, 2014, 12:19 p.m.) Review request for Plasma. Changes ------- spiffed up the share engine's package structure cmake file. Repository: plasma-workspace Description ------- This patchset introduces the use of PackageStructure plugins to plasma-workspace, allowing the removal of ShellPluginLoader everywhere. It also fixes some strange use of PackageStructure in the share DataEngine and updates that PackageStructure to use the JSON-based loading. With this changeset Plasma/Shell, Plasma/LookAndFeel and Plasma/Wallpaper are all plugins and accessible from everywhere that needs them via Plasma::PluginLoader. Diffs (updated) ----- shell/packageplugins/wallpaper/wallpaper.cpp PRE-CREATION shell/plasmaquick/shellpluginloader.h ea0755e4abe841e33777d89cb12a5e689161e51b shell/shellcorona.cpp 312003f6f1a27b1c624da17c310a148dff7131a3 shell/CMakeLists.txt d67be9782de1faa9890bf85b8b2b517e15f12812 shell/main.cpp 04e1fd168df15bced40bfd84b965fb6f4905ded6 shell/osd.cpp 961c9ca3974337553bcefc1fc2c06222da9114e1 shell/packageplugins/CMakeLists.txt PRE-CREATION shell/packageplugins/layouttemplate/CMakeLists.txt PRE-CREATION shell/packageplugins/layouttemplate/layouttemplate.h PRE-CREATION shell/packageplugins/layouttemplate/layouttemplate.cpp PRE-CREATION shell/packageplugins/layouttemplate/plasma-packagestructure-layouttemplate.desktop PRE-CREATION shell/packageplugins/lookandfeel/CMakeLists.txt PRE-CREATION shell/packageplugins/lookandfeel/lookandfeel.h PRE-CREATION shell/packageplugins/lookandfeel/lookandfeel.cpp PRE-CREATION shell/packageplugins/lookandfeel/plasma-packagestructure-lookandfeel.desktop PRE-CREATION shell/packageplugins/packages.h PRE-CREATION shell/packageplugins/packages.cpp PRE-CREATION shell/packageplugins/shell/CMakeLists.txt PRE-CREATION shell/packageplugins/shell/Messages.sh PRE-CREATION shell/packageplugins/shell/plasma-packagestructure-plasma-shell.desktop PRE-CREATION shell/packageplugins/shell/shellpackage.h PRE-CREATION shell/packageplugins/shell/shellpackage.cpp PRE-CREATION shell/packageplugins/wallpaper/CMakeLists.txt PRE-CREATION shell/packageplugins/wallpaper/plasma-packagestructure-wallpaper.desktop PRE-CREATION shell/packageplugins/wallpaper/wallpaper.h PRE-CREATION dataengines/share/shareprovider.h c9159cdde6a858fbdca57ad7c5aa258028fd9ac3 dataengines/share/shareprovider.cpp fd1812fa1263cdf9df7d4340c681a63f8455ce07 dataengines/share/shareservice.h 5fb533d06fc74a52c33e0c8e1052ec93ffc4e11f dataengines/share/shareservice.cpp 8442b6634e5e55f8717b9684dd41839df8d3d677 krunner/main.cpp 408c5631a8007ac2617c7963cd83146dc4bbceeb krunner/shellpluginloader.h 9c0f62412eac4d1ad03c681325852d9efe25ccda krunner/view.cpp 0d986e845e3b9821ef39a874d431a087e2390e8a ksmserver/screenlocker/greeter/greeterapp.cpp 92e839091412585dddc369d5a4a3beace39e92ae ksmserver/shellpluginloader.h 6f13d493a800a7479711ef3549cfd9362a593778 ksmserver/shutdowndlg.cpp b4e59a387e5bf857db6314cf1b879e6a775e9f99 lookandfeelaccess/lookandfeelaccess.cpp 474e06d7b189fc368d1f9ba45426ea30392e2a71 lookandfeelaccess/shellpluginloader.h 9c0f62412eac4d1ad03c681325852d9efe25ccda plasma-windowed/main.cpp 4e9263aad9736b93dc00e7fef74db54b39456cb6 plasma-windowed/plasmaquick/shellpluginloader.h ea0755e4abe841e33777d89cb12a5e689161e51b dataengines/share/packagestructure/CMakeLists.txt PRE-CREATION dataengines/share/plugin_share_package.cpp c4e2f23f7a65ddc67a94c60dffa3f71701a46b8b dataengines/share/share_package.h dataengines/share/share_package.cpp 13f41def3abd5ccf57b8745e3fd6956d10377a7a dataengines/share/CMakeLists.txt 3d67b137f9a3e37453b8890d0d3c73e6469bae38 dataengines/share/data/CMakeLists.txt e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 dataengines/share/data/plasma-packagestructure-share.desktop Diff: https://git.reviewboard.kde.org/r/119989/diff/ Testing ------- Ran a full Plasma Desktop session with these changes. Thanks, Aaron J. Seigo
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel