> On Sept. 3, 2014, 10:22 p.m., David Edmundson wrote: > > components/keyboardlayout/CMakeLists.txt, line 1 > > <https://git.reviewboard.kde.org/r/120051/diff/1/?file=309589#file309589line1> > > > > This can't go in components. > > There was a review comment once with a fear components could become a > > dumping ground for random items, I'll concede they might have had a point. > > > > Brainstorm: > > 1) In plasma-desktop with the daemon. (it's where the old plasmoid was > > before). Though it'd be weird for a desktop KCM to install plugins > > potentially used by workspace. > > > > 2) we make a folder like dataengines (or even a subfolder inside > > dataengines) for plugins like this and the ineviatble future things like > > this > > > > 3) we put this in applets/keyboardlayout/plugin and: > > 3.1) the lockscreen imports org.kde.plasma.keyboardlayout from the > > applet > > 3.2) the lockscreen has a set(lockscreen_SRCS > > /../../applets/keyboardlayout/plugin/keyboardlayout.cpp) and we just build > > the file in two places > > > > 4) KDeclarative, if there's an application use?
What's the difference between 2) and using plasma-workspace/components? Actually I think that components fits quite well, because it's a component and it's meant to be used by the workspace (and dependencies of). - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120051/#review65778 ----------------------------------------------------------- On Sept. 3, 2014, 6:39 p.m., Martin Yrjölä wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120051/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2014, 6:39 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Makes the screenlocker's keyboard layout switcher plugin globally > accessible. This is needed for a keyboard layout switcher plasmoid > in kdeplasma-addons. > > > Diffs > ----- > > ksmserver/screenlocker/greeter/keyboardlayout.h > ksmserver/screenlocker/greeter/keyboardlayout.cpp > lookandfeel/contents/components/KeyboardLayout.qml > f0198ae519ed7c7e3f3e8fa9ef637302680f4182 > lookandfeel/contents/lockscreen/LockScreen.qml > 82acdd6c569622cfca983156ef4b09cd9176417f > ksmserver/screenlocker/greeter/CMakeLists.txt > 611a151826e8b9d5002233960192e131ba1ca93c > ksmserver/screenlocker/greeter/greeterapp.cpp > 86794371c6211f3ff2f58717bc91a096a17ad7d3 > components/CMakeLists.txt ac468c0ffdf75f614f5995cbd42bb8d3568e81fc > components/keyboardlayout/CMakeLists.txt PRE-CREATION > components/keyboardlayout/keyboardlayoutplugin.h PRE-CREATION > components/keyboardlayout/keyboardlayoutplugin.cpp PRE-CREATION > components/keyboardlayout/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120051/diff/ > > > Testing > ------- > > Tested that org.kde.plasma.workspace.keyboardlayout can be imported in > plasmoids in kdeplasma-addons. > > Confirmed that the layout switcher still works in the screen locker. > > Test number 6 fails for me both with and without this commit. Is this a known > issue? How should I proceed with this? > ` 6/10 Test #6: ksmserver-lockWindowTest ......................***Failed > 3.52 sec` > > > Thanks, > > Martin Yrjölä > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
