-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120235/#review66684
-----------------------------------------------------------
We currently have the following ways of changing the dialog size
1. By changing the mainItem size
2. By actually changing the size of the dialog via QML
3. Window Managers
(3) is not something that is exposed to the user since the dialog never
actually has the border. I think we can safely ignore this one. Also, maybe can
explicitly set some window flags to tell the WM to never allow the client to
resize the window.
(2) kind of makes sense except that then maybe we shouldn't have (1). Example -
Dialog {
width: 500
height: 500
mainItem : Rectangle {
width : 200
height: 200
}
}
What do you think should be happening in this case? It's not obvious. I propose
we make the mainItem responsible for the dialog size. The 'width' and 'height'
properties of the Dialog can be made read only.
- Vishesh Handa
On Sept. 16, 2014, 3:52 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120235/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2014, 3:52 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> A dialog can be resize for two reasons: the mainItem size changes, or the
> dialog size changes.
>
> the first can happen programmatically, caused by the Layout, or just by
> assigning the width.
>
> the second can be caused either programmatically, assigning the size of the
> dialog or externally by the windowmanager, that is the only one theat in the
> end has the only final control of the window size
>
>
> Diffs
> -----
>
> src/plasmaquick/dialog.cpp 79a871b
> tests/dialog_minWidthHeightRepositioning.qml 37bd622
>
> Diff: https://git.reviewboard.kde.org/r/120235/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Marco Martin
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
