-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120248/#review66766
-----------------------------------------------------------


hmm, not sure is the correct way, setting implicitsizes should be expected to 
work correctly and not be rewrittten by the component.

maybe it should check at componentcomplete if at that point impolicitWidth has 
been set by the user

- Marco Martin


On Sept. 17, 2014, 6:22 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120248/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 6:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Override the implicitSizes in the ruler completley
> 
> Needed to fix: https://gerrit.vesnicky.cesnet.cz/r/#/c/41/2
> Though I think that change was correct (and so is this one)
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/panelconfiguration/Ruler.qml 6cdccc9 
> 
> Diff: https://git.reviewboard.kde.org/r/120248/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to