> On Sept. 18, 2014, 10:11 p.m., Aleix Pol Gonzalez wrote: > > Shouldn't it be called SimpleCorona? Or maybe WindowedCorona? > > It's not a shell anymore, in this case.
hmm, maybe. technically it is since it loads plasmoids. but yeah, windowedcorona sounds good, +1 - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120270/#review66891 ----------------------------------------------------------- On Sept. 18, 2014, 6:33 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120270/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 6:33 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > this adds an option to plasma-windowed to run a shell package together with a > containment in its own window/process. > it's intended for full applications done just in qml that want to host > widgets as well, like plasma-mediacenter. > This is part of getting all the needed shells in the same place, so they will > be able to return in plasma-framework and the libplasmaquick library not be > exported anymore > > > Diffs > ----- > > plasma-windowed/CMakeLists.txt 252724a > plasma-windowed/main.cpp 649bd39 > plasma-windowed/plasmawindowedcorona.h 8e6fd76 > plasma-windowed/plasmawindowedcorona.cpp 3dee283 > plasma-windowed/simpleshellcorona.h PRE-CREATION > plasma-windowed/simpleshellcorona.cpp PRE-CREATION > plasma-windowed/simpleshellview.h PRE-CREATION > plasma-windowed/simpleshellview.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120270/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel