> On Sept. 20, 2014, 4 p.m., Bhushan Shah wrote: > > dataengines/comic/CMakeLists.txt, line 82 > > <https://git.reviewboard.kde.org/r/120276/diff/2/?file=313487#file313487line82> > > > > Why this is commented out?
The file does not exist anymore; It had only the EXPORT macro in it anyway and i advised to move it to the .cpp and remove that file. This line should just be removed. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review67074 ----------------------------------------------------------- On Sept. 19, 2014, 9:17 p.m., Andrei Amuraritei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120276/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 9:17 p.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, and Sebastian > Kügler. > > > Repository: kdeplasma-addons > > > Description > ------- > > comic DataEngine initial port to frameworks. > > > Diffs > ----- > > dataengines/comic/plasma-packagestructure-comic.desktop 67f96c0 > dataengines/comic/comic_package.cpp 6d2ff0b > dataengines/comic/comicprovider.h 630ee8d > dataengines/comic/comicprovider.cpp ab248a5 > dataengines/comic/comicproviderkross.h 46a9072 > dataengines/comic/comicproviderkross.cpp 9820f05 > dataengines/comic/comicproviderwrapper.h 81eee68 > dataengines/comic/comicproviderwrapper.cpp 48ced42 > dataengines/comic/plasma-dataengine-comic.desktop f9e5433 > dataengines/comic/CMakeLists.txt 8e382e6 > dataengines/comic/cachedprovider.cpp caca25e > dataengines/comic/comic.h 8cc3969 > dataengines/comic/comic.cpp 7130f44 > dataengines/comic/comic_package.h 32be381 > > Diff: https://git.reviewboard.kde.org/r/120276/diff/ > > > Testing > ------- > > Building from source, compiles 100%, some deprecated warnings. DataEngine > shows up in plasmaengineexplorer and detects installed .comic packages. > This is the initial port, still need to review code to fix issues like > whitespaces around ( or the deprecated parts. > Thanks notmart, d_ed, sebas, bshas etc for helping. > > > Thanks, > > Andrei Amuraritei > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel