----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120316/ -----------------------------------------------------------
(Updated Sept. 22, 2014, 6 p.m.) Review request for Plasma. Changes ------- use a different corona for the standalone mode, doesn't overcomplicate it. scriptengine becomes slightly uglier tough Repository: plasma-workspace Description ------- This is as alternative to https://git.reviewboard.kde.org/r/120270/ with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated. It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday). One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated) Diffs (updated) ----- shell/shellmanager.cpp f6472cb shell/standaloneappcorona.h PRE-CREATION shell/standaloneappcorona.cpp PRE-CREATION shell/scripting/scriptengine.cpp 5b035ea shell/shellcorona.cpp eeb01af shell/shellmanager.h eef25aa shell/main.cpp e737007 shell/scripting/scriptengine.h 6ce8b51 shell/CMakeLists.txt e835bf8 shell/desktopview.h 6aeeeb6 shell/desktopview.cpp 08c1c32 Diff: https://git.reviewboard.kde.org/r/120316/diff/ Testing ------- Thanks, Marco Martin
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
