> On Sept. 25, 2014, 9:33 vorm., Kai Uwe Broulik wrote: > > Can you provide a screenshot of the tooltip? > > Jeremy Whiting wrote: > I'm using the same function to create the time format. but with a > different argument. I guess I could make two separate functions instead, but > why not just use the same one, when 90% of the code is the same? > Anyway, I've added a couple screenshots http://imgur.com/biI6prN,lbxJS4k > and http://imgur.com/biI6prN,lbxJS4k#1 though when I look at it admittedly > the withDate one looks funny, and should have the timezone first like the > other one and outside of () also. I'll fix that and post an update to this > review.
Fair enough. Looks better than I expected. Yes, the date and the order looks awkward, and please add an empty line between the current date and the list of time zones. Thanks! - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120358/#review67406 ----------------------------------------------------------- On Sept. 25, 2014, 5:49 nachm., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120358/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 5:49 nachm.) > > > Review request for Plasma, Kai Uwe Broulik and Martin Klapetek. > > > Repository: plasma-workspace > > > Description > ------- > > DigitalClock: Add timezone information to digital clock tooltip. > > note: My editor is dumb and removed the umlaut from Sebas' name, I'll fix > that before committing. > > > Diffs > ----- > > applets/digital-clock/package/contents/ui/DigitalClock.qml > 00c9def8dffe1cdc24d377acab029b47bd57e602 > > Diff: https://git.reviewboard.kde.org/r/120358/diff/ > > > Testing > ------- > > I ran it here with two timezones selected (Local and London). The date is > local date, but it was that way before anyway. The date next to each timezone > is the date for that timezone if dates are shown. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
