----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120455/ -----------------------------------------------------------
(Updated Oct. 1, 2014, 6:34 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Repository: plasma-desktop Description ------- Avoid a lot of syncs to FavoritesModel in kickoff Current code loaded the list of favourites into a string. It then readded them one by one syncing the config after each change. At the end the config is the same as when we started but with n config writes in the meantime. Splitting add and load methods solves this. This should hopefully fix lockups as we're no longer writing to kickoffrc so often on load as well as give us a significant speed boost on the initial open. BUG: 339451 Diffs ----- applets/kickoff/core/favoritesmodel.h 27a0626 applets/kickoff/core/favoritesmodel.cpp f05588b Diff: https://git.reviewboard.kde.org/r/120455/diff/ Testing ------- Put a breakpoint on Kickoff::FavoritesModel::Private::save checked this wasn't called anymore and favourites still loaded correctly. Thanks, David Edmundson
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
