> On Oct. 7, 2014, 12:23 a.m., Martin Klapetek wrote: > > Minor issues and +1 to Martin G's note about commented out debugs...imo > > they should just go
ok, will remove it in final revision > On Oct. 7, 2014, 12:23 a.m., Martin Klapetek wrote: > > tests/CMakeLists.txt, line 7 > > <https://git.reviewboard.kde.org/r/120441/diff/3/?file=316814#file316814line7> > > > > Is the I18n still needed here in the tests linkage? I see only the > > signalplottertest.cpp using i18n (and even that usage could possibly be > > removed but meh, it's just tests) > > Lukáš Tinkl wrote: > Tests shouldn't contain i18n() the linkage is also due to signalplotter/ksignalplotter.h include in various tests > On Oct. 7, 2014, 12:23 a.m., Martin Klapetek wrote: > > signalplotter/ksignalplotter.cpp, line 115 > > <https://git.reviewboard.kde.org/r/120441/diff/3/?file=316813#file316813line115> > > > > This should probably be qCDebug to keep the category sure, can take care of that. i'd like to do that in separate commit, as it's not strictly porting away from KDELibs4Support - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120441/#review68025 ----------------------------------------------------------- On Oct. 6, 2014, 6:29 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120441/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 6:29 p.m.) > > > Review request for Plasma. > > > Repository: libksysguard > > > Description > ------- > > some libs needed just headers removal, other something more ... > found out that just by calling find_package(KF5KDELibs4Support) adds compat > macros, even w/o linking to it. > > > Diffs > ----- > > CMakeLists.txt 61bd704 > ksgrd/CMakeLists.txt 64ad24a > ksgrd/SensorManager.cpp 9e1534a > lsofui/CMakeLists.txt 2b0c8ac > lsofui/lsof.h e87ac26 > processcore/CMakeLists.txt 0ca833e > processcore/processes.cpp 3e63218 > processcore/processes_atop_p.cpp 369df36 > processcore/processes_remote_p.cpp 361bf24 > processui/CMakeLists.txt 150e198 > processui/KTextEditVT.cpp 064737b > processui/ProcessFilter.cpp b37766e > processui/ProcessModel.cpp 8b87d41 > processui/ProcessModel_p.h 6bc9d09 > processui/ReniceDlg.h fa445a5 > processui/ReniceDlg.cpp 218412c > processui/ksysguardprocesslist.cpp d3403cc > processui/scripting.cpp fd0a610 > signalplotter/CMakeLists.txt 67aa8bb > signalplotter/kgraphicssignalplotter.h 9f698d4 > signalplotter/ksignalplotter.cpp 91d9eee > tests/CMakeLists.txt a74c6a2 > tests/graphicssignalplotterbenchmark.cpp e27eb1a > tests/processtest.cpp 6aa9809 > tests/signalplotterbenchmark.cpp 8b827d6 > tests/signalplottertest.cpp bb2108e > > Diff: https://git.reviewboard.kde.org/r/120441/diff/ > > > Testing > ------- > > builds, tests pass, ksysguard functions as it did > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
