----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120471/#review68073 -----------------------------------------------------------
src/client/registry.cpp <https://git.reviewboard.kde.org/r/120471/#comment47447> this would crash - please use a test case for it. The destroy is intended to be used to clean up cleanly in case the Wayland connection died. So calling into any wayland client library call would crash. There should be a test for destroy handling, please extend that one. - Martin Gräßlin On Okt. 7, 2014, 11:12 vorm., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120471/ > ----------------------------------------------------------- > > (Updated Okt. 7, 2014, 11:12 vorm.) > > > Review request for kwin, Plasma and Martin Gräßlin. > > > Repository: kwayland > > > Description > ------- > > Add Registry::sync() signal > > Emitted when the Wayland display is done flushing the initial interface > callbacks, announcing wl_display properties. This can be used to compress > events. Note that this signal is emitted only after announcing interfaces, > such as outputs, but not after receiving callbacks of interface properties, > such as the output's geometry, modes, etc.. > This signal is emitted from the wl_display_sync callback. > > For this, we add a wl_callback_listener to the registry's Private, > enqueue its events properly, if necessary, and trigger the signal > through a callback mechanism similar to the wl_registry callbacks. > > This signal allows users of the API to find out when the signal > emissions, such as outputAnnounced, etc. for all currently existing > interfaces is complete. > > > Diffs > ----- > > autotests/client/test_wayland_registry.cpp 571be0f > src/client/registry.h 9e63a2b > src/client/registry.cpp 22f9484 > > Diff: https://git.reviewboard.kde.org/r/120471/diff/ > > > Testing > ------- > > tests in libkscreen exercise this feature, it works as expected, meaning I > can notify when all initial synchronization is done. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
