----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120885/ -----------------------------------------------------------
(Updated Oct. 29, 2014, 10:16 a.m.) Review request for Plasma. Repository: plasma-framework Description ------- Redone here, that seems a bit more understandable than gerrit. It introduces a new status for applets, AwaitingDeletionStatus. triggering the delete action, puts the applet in AwaitingDeletionStatus. triggering it again it really deletes it. A notification with an undo action is emitted when the applet goes in AwaitingDeletionStatus. The appelt is really deleted when either: * A minute timeout expires * The user manually closes the notification * Plasma is shut down and the applet is in awaitingdeletion status It would then be job for the qml part to actually hide applets that are AwaitingDeletionStatus as they don't exist anymore. Diffs (updated) ----- src/plasma/plasma.h 15c346b src/plasma/private/applet_p.h 76a1270 src/plasma/private/applet_p.cpp 44ecd25 src/plasma/private/containment_p.cpp 3836772 src/scriptengines/qml/plasmoid/appletinterface.cpp 24a36b3 CMakeLists.txt 10c0ef4 src/plasma/CMakeLists.txt 7cc2fe3 src/plasma/applet.cpp f4b5410 src/plasma/data/notifications/plasmashell.notifyrc PRE-CREATION src/scriptengines/qml/plasmoid/containmentinterface.cpp fae64c6 Diff: https://git.reviewboard.kde.org/r/120885/diff/ Testing ------- I'm not 100% sold on the technical approach on how is done, but it seems to work reliably Thanks, Marco Martin
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
