> On Oct. 29, 2014, 12:57 p.m., Kai Uwe Broulik wrote:
> > tabbox/qml/clients/scaling/contents/ui/main.qml, line 405
> > <https://git.reviewboard.kde.org/r/109832/diff/3/?file=321190#file321190line405>
> >
> > i18n this?
>
> Andre Heinecke wrote:
> I don't think this is neccessary. The braces are just used to indicate
> that a window is minimized. They have no lingustic meaning in this context.
>
> Kai Uwe Broulik wrote:
> You cannot assume that a language uses exactly this kind of braces in
> that order:
> i18nc("braces just denote the window is minimized", "(%1)", text)
>
> Martin Klapetek wrote:
> It's not about linguistic meaning, it's more about if those ()s will make
> sense in eg. Japaneese language or Arabic.
>
> Simple rule to remember: "if the string is going to appear anywhere on
> the screen, the whole string must be in i18n" ;)
>
> Martin Gräßlin wrote:
> the usage of ()s for minimized windows has been used in KWin without i18n
> since at least as long as I'm involved in the project. I can look up when it
> got introduced and I would not be surprised if it's since KDE 2.0. Given that
> and no translators ever complained, I wouldn't change it ;-)
just for the fun I looked into the history and found the following in
tabbox.cpp:
+ if (client->isIconified())
+ s += QString("(")+client->caption()+")";
+ else
now guess the commit :-)
commit 311db796c68e520e5b6d28829d6aaa4bfbcd1536
Author: Matthias Ettrich <ettr...@troll.no>
Date: Thu Aug 19 23:26:42 1999 +0000
Say hello to kwin. WARNING: NOT USABLE YET. See README.
svn path=/trunk/kdebase/kwin/; revision=27871
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109832/#review69422
-----------------------------------------------------------
On Oct. 29, 2014, 4:22 p.m., Andre Heinecke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/109832/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 4:22 p.m.)
>
>
> Review request for kwin, Plasma and Martin Gräßlin.
>
>
> Bugs: 292566
> http://bugs.kde.org/show_bug.cgi?id=292566
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> I'm reopening this review request as I have updated this Window Switcher for
> Plasma 5.1 and would like to get another review to check if there are any
> suggestions or issues regarding the port to the new API.
>
> Secondly I would like to ask again to have this Window Switcher Layout
> included in the KWin repository. I would prefer it if users could obtain this
> layout from their trusted distributors and did not have to rely on an
> unverifyable third party download to obtain this plugin.
>
> As suggested in the original review I've put this up on kde-look and recieved
> some positive feedback. But I really feel that it is rotting away there and
> that KDE-Look is not a good place to distribute executable plugins.
>
> IMHO the approach of this Window Switcher is different enough from the others
> included in KWin to be a useful addition to the fold. Especially as this
> behavior is already familiar to KDE users from some versions < 4.6
>
> It should also be close enough to the other layouts like thumbnails to keep
> maintenance very similar (I've mostly looked at the changes made to
> thumbnails to adapt this for Plasma 5)
>
>
> Original description:
>
> This Layout tries to mimic some of the old KDE 4.6 tabbox behavior and
> layout, it scales the thumbnails shown in the tabbox to avoid scrolling.
> There are also three different states in this layout depending on the size of
> the scaled thumbnails to provide appropriate information even when there are
> many opened windows.
>
> States:
> 1. Thumbnails are larger then 200px: Show the Title and the Icon of the
> Window directly below the thumbnail.
> 2. Thumbnails are between 200px and 64px: Thumbnails are shown together with
> the icon but only the title of the currently selected window is shown.
> 3. Thumbnails would be smaller then 64px: Only the Icons of the windows are
> shown and the title of the currently selected window (like big icons)
> If the Thumbnails would be smaller then 32px the tabbox starts to scroll in
> the Icon Only state.
>
> Size of the thumbnails depends on the screen size and the number of opened
> windows.
>
>
> Diffs
> -----
>
> tabbox/qml/CMakeLists.txt fc55ab9
> tabbox/qml/clients/scaling/contents/ui/main.qml PRE-CREATION
> tabbox/qml/clients/scaling/metadata.desktop PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/109832/diff/
>
>
> Testing
> -------
>
> Tested with plasma 5.3.1 from Kubuntu next / unstable repositories.
>
>
> Thanks,
>
> Andre Heinecke
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
