> On Nov. 4, 2014, 11:59 a.m., Kai Uwe Broulik wrote:
> > Who's responsible for setting the dedicated replacement
> > QStyle::styleHint(SH_Widget_Animate)?
> > Is it now up to the style then, ie. animations turned on/off in
> > Oxygen/Breeze?
>
> David Edmundson wrote:
> Turns out that was a very good question.
>
> frameworkintegration/src/kstyle/kstyle.cpp
> case SH_Widget_Animate: {
> KConfigGroup g(KSharedConfig::openConfig(), "KDE-Global GUI
> Settings");
> return g.readEntry("GraphicEffectsLevel", true);
> }
>
> So we were using this config entry, but writing it as an integer and
> reading it as a boolean. So it was animated for everything, except: "Low
> display resolution and Low CPU"
Personal opinion: this shouldn't be on any config option at all. If at all the
animation setting should get derived from the hardware. If a style wants to
expose an option that's fine, but it should be in the style specific config..
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120970/#review69791
-----------------------------------------------------------
On Nov. 4, 2014, 11:55 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120970/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 11:55 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Remove combo "Graphical Effects"
>
> It set a config value which was exposed in
> KGlobalSettings::graphicEffectsLevel that is now deprecated.
>
>
> Diffs
> -----
>
> kcms/style/finetuning.ui 3abb692
> kcms/style/kcmstyle.cpp 6585ee6
>
> Diff: https://git.reviewboard.kde.org/r/120970/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
