----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121121/#review70376 -----------------------------------------------------------
AuthDialog.cpp <https://git.reviewboard.kde.org/r/121121/#comment49204> Shouldn't this be one i18n("Details >>") to avoid string puzzles? Would require another "Details <<" though, but that's necessary for RTL languages anyway (no?) - Martin Klapetek On Nov. 14, 2014, 6:08 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121121/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 6:08 p.m.) > > > Review request for Plasma, Jaroslav Řezník and Lukáš Tinkl. > > > Repository: polkit-kde-agent-1 > > > Description > ------- > > Remove all kdelibs4support from polkit-agent > > > Diffs > ----- > > AuthDialog.h eaebbd2 > AuthDialog.cpp b76d91e > AuthDialog.ui e4da0f9 > CMakeLists.txt 482fc57 > main.cpp f8f97b8 > policykitkde.h 85ce6b2 > policykitkde.cpp a25cb4f > policykitlistener.h 538381f > policykitlistener.cpp bab7fdf > > Diff: https://git.reviewboard.kde.org/r/121121/diff/ > > > Testing > ------- > > Using pkexec tested using the correct password the wrong password viewing > details and tested trying to open two agents at once. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
